Horton

Re: [PATCH] Little refactoring of portalcmds.c

Quan Zongliang <quanzongliang@yeah.net>

View thread
From: Quan Zongliang <quanzongliang@yeah.net>
To: Aleksander Alekseev <aleksander@tigerdata.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-10-27T06:02:41Z
Lists: pgsql-hackers 

On 10/8/25 10:02 PM, Aleksander Alekseev wrote:
> Hi,
> 
> The proposed patch places some repetitive code in a helper function.
> The value of this change is arguably not that high but it makes the
> code a bit neater IMO.
> 

It also reduces the ease of reading the code.
Just add a function for a single if statement. I don't think it's necessary.

Regards,
Quan Zongliang