Horton

Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

Alexey Kondratov <a.kondratov@postgrespro.ru>

View thread
From: Alexey Kondratov <a.kondratov@postgrespro.ru>
To: David Steele <david@pgmasters.net>, Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Dmitry Dolgov <9erthalion6@gmail.com>, Michael Paquier <michael@paquier.xyz>, vladimirlesk@yandex-team.ru, dsarafan@yandex-team.ru
Date: 2019-03-07T12:27:25Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Move frontend-side archive APIs from src/common/ to src/fe_utils/

  2. Add -c/--restore-target-wal to pg_rewind

  3. Move routine definitions of xlogarchive.c to a new header file

  4. Move routine building restore_command to src/common/

  5. Integrate recovery.conf into postgresql.conf

Attachments

On 07.03.2019 10:26, David Steele wrote:
> On 3/6/19 5:38 PM, Andrey Borodin wrote:
>>
>> The new patch is much smaller (less than 400 lines) and works as 
>> advertised.
>> There's a typo "retreive" there.

Ough, corrected this in three different places. Not my word, definitely. 
Thanks!

>>
>> These lines look a little suspicious:
>>         char  postgres_exec_path[MAXPGPATH],
>>                   postgres_cmd[MAXPGPATH],
>>                   cmd_output[MAX_RESTORE_COMMAND];
>> Is it supposed to be any difference between MAXPGPATH and 
>> MAX_RESTORE_COMMAND?
>>

Yes, it was supposed to be, but after your message I have double checked 
everything and figured out that we use MAXPGPATH for final 
restore_command build (with all aliases replaced). Thus, there is no 
need in a separated constant. I have replaced it with MAXPGPATH.

>
> This patch appears to need attention from the author so I have marked 
> it Waiting on Author.
>

I hope I have addressed all issues in the new patch version which is 
attached. Also, I have added more detailed explanation of new 
functionality into the multi-line commit-message.


Regards,

-- 
Alexey Kondratov

Postgres Professional https://www.postgrespro.com
Russian Postgres Company