Horton
Menu

Re: Amcheck verification of GiST and GIN

Tomas Vondra <tomas@vondra.me>

View thread
From: Tomas Vondra <tomas@vondra.me>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Kirill Reshke <reshkekirill@gmail.com>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>, Alexander Lakhin <exclusion@gmail.com>, Andrey Borodin <amborodin86@gmail.com>, Peter Geoghegan <pg@bowt.ie>, Jose Arthur Benetasso Villanova <jose.arthur@gmail.com>, Andres Freund <andres@anarazel.de>, Nikolay Samokhvalov <samokhvalov@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-02-21T18:15:09Z
Lists: pgsql-hackers 
On 2/21/25 18:07, Mark Dilger wrote:
> 
> 
>> On Feb 21, 2025, at 6:29 AM, Tomas Vondra <tomas@vondra.me> wrote:
>> 
>> Hi,
>> 
>> I see this patch didn't move since December :-( I still think
>> these improvements would be useful, it certainly was very helpful
>> when I was working on the GIN/GiST parallel builds (the GiST
>> builds stalled, but I hope to push the GIN patches soon).
>> 
>> So I'd like to get some of this in too. I'm not sure about the
>> GiST bits, because I know very little about that AM (the parallel
>> builds made me acutely aware of that).
>> 
>> But I'd like to get the GIN parts in. We're at v34 already, and
>> the recent changes were mostly cosmetic. Does anyone object to me
>> polishing and pushing those parts?
> 
> I infer that you intend to make v34-0004, v34-0006, and v35-0001
> apply cleanly without the other patches and commit it that way.  If
> that is correct, be advised that I'm doing a review and will respond
> back shortly, maybe in a few hours.
> 

Something like that. I haven't tried to actually massage the patches
yet, maybe it'd require some of the refactoring patches too.

But OK, I'll wait for the review, no problem. I wouldn't get to this
until Monday anyway.


regards

-- 
Tomas Vondra

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. amcheck: Fix posting tree checks in gin_index_check()

  2. amcheck: Fix parent key check in gin_index_check()

  3. amcheck: Fix checks of entry order for GIN indexes

  4. amcheck: Remove unused GinScanItem->parentlsn field

  5. amcheck: Test gin_index_check on a multicolumn index

  6. Remove incidental md5() function use from test

  7. amcheck: Add a GIN index to the CREATE INDEX CONCURRENTLY tests

  8. amcheck: Add a test with GIN index on JSONB data

  9. amcheck: Fix indentation in verify_gin.c

  10. amcheck: Add gin_index_check() to verify GIN index

  11. amcheck: Move common routines into a separate module

  12. Fix grammar in GIN README

  13. Avoid amcheck inline compression false positives.