Re: table_tuple_lock's snapshot argument

Heikki Linnakangas <hlinnaka@iki.fi>

From: Heikki Linnakangas <hlinnaka@iki.fi>

To: Ranier Vilela <ranier.vf@gmail.com>

Cc: Alexander Korotkov <aekorotkov@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2025-03-10T16:52:50Z

Lists: pgsql-hackers

On 10/03/2025 18:20, Ranier Vilela wrote:
> Just for curiosity.
> *RelationFindReplTupleSeq* on the same source, does not suffer
> from the same issue?
> 
> PushActiveSnapshot(GetLatestSnapshot());
> 
> res = table_tuple_lock(rel, &(outslot->tts_tid), GetLatestSnapshot(),

:facepalm: yep, it sure does, and FindConflictTuple() too. Thanks, I'll 
go fix those too.

-- 
Heikki Linnakangas
Neon (https://neon.tech)

Commits

Fix a few more redundant calls of GetLatestSnapshot()
- 6c1e79589ae8 13.21 landed
- 136e68b465c1 14.18 landed
- d765226cb9d2 15.13 landed
- 324e0b656b4b 16.9 landed
- f1ef111a0940 17.5 landed
- f7c566a1a276 18.0 landed
Fix snapshot used in logical replication index lookup
- 9b3914f18165 13.21 landed
- 2ef048855fdc 14.18 landed
- 50c5899922c3 15.13 landed
- 8171d2dae93d 16.9 landed
- c1dd3a944399 17.5 landed
- 23675031774c 18.0 landed
tableam: Add tuple_{insert, delete, update, lock} and use.
- 5db6df0c0117 12.0 cited