Re: why -Fdance archive format option works with ./pg_restore but not with ./pg_dump?

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>
To: Srinath Reddy <srinath2133@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-01-24T14:14:59Z
Lists: pgsql-hackers
On 2025-01-24 Fr 3:04 AM, Srinath Reddy wrote:
>
>
> On Fri, Jan 24, 2025 at 1:42 AM Andrew Dunstan <andrew@dunslane.net> 
> wrote:
>
>
>     `git blame` tells me that this switch statement goes back to 2001.
>     Seeking a reason at this distance is unlikely to be productive.
>     Probably
>     we were not nearly as careful then as we are now about such
>     things. Feel
>     free to submit a patch tightening the test.
>
>
>
> Hi Andrew,
> thanks for the reply,here's the patch for the same.
>
>


I don't think we need a new file for this. pg_backup_utils.c is already 
there for routines common to pg_restore and pg_dump.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Commits

  1. Tighten pg_restore's recognition of its -F (format) option values.