Re: [PATCH] Add section headings to index types doc
Jürgen Purtz <juergen@purtz.de>
From: Jürgen Purtz <juergen@purtz.de>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-10-25T09:40:07Z
Lists: pgsql-hackers
Attachments
- 0003-index-types-vs-master.patch (text/x-patch) patch 0003
- 0003-index-types.patch (text/x-patch) patch 0003
On 23.10.20 18:08, David G. Johnston wrote: > On Fri, Oct 23, 2020 at 3:18 AM Jürgen Purtz <juergen@purtz.de > <mailto:juergen@purtz.de>> wrote: > >> and add a link to the "CREATE INDEX" command from the chapter >> preamble. > is the link necessary? > > > I suppose it would make more sense to add it to the previous section - > the introduction page. I do think having a link (or more than one) to > CREATE INDEX from the Indexes chapter is reader friendly. Having > links to SQL commands is never truly necessary - the reader knows a > SQL command reference exists and the name of the command allows them > to find the correct page. > > David J. > I'm afraid I haven't grasped everything of your intentions and suggestions of your last two mails. - equal operator in standalone paragraph: ok, integrated. - shift "create index ... using HASH" to a different place: You suggest shifting the statement or a link to the previous (sub-)chapter "11.1 Introduction"? But there is already a "create index" example. Please read my suggestion/modification in the first paragraph of the "11.2 Index Types" page. - "rewording hash": I don't know what is missing here. But I have added a few words about the nature of this index type. Attached are two patches: a) summary against master and b) standalone of my current changes. -- J. Purtz
Commits
-
Doc: minor improvements for section 11.2 "Index Types".
- 85b4ba73423b 14.0 landed