Horton

Re: [HACKERS] wrong t_bits alignment in pageinspect

Maksim Milyutin <milyutinma@gmail.com>

View thread View on postgr.es
From: Maksim Milyutin <milyutinma@gmail.com>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2018-01-04T18:06:09Z
Lists: pgsql-hackers

Attachments

Hi!


02.01.2018 12:33, Andrey Borodin wrote:
>> 15 дек. 2017 г., в 18:53, Maksim Milyutin <milyutinma@gmail.com> написал(а):
>>
>> I found out the problem in exposing values of t_bits field from heap_page_items function.
> Probably, this [0] place contains similar bug too?
>
> [0] https://github.com/postgres/postgres/blob/master/contrib/pageinspect/heapfuncs.c#L439

Yes, it's so. Thanks a lot for notice.

Attached a new version of patch with regression test.

-- 
Regards,
Maksim Milyutin

Commits

  1. Fix new test case to not be endian-dependent.

  2. Fix incorrect computations of length of null bitmap in pageinspect.