Horton
Menu

Re: recovery.signal not cleaned up when both signal files are present

David Steele <david@pgbackrest.org>

View thread
From: David Steele <david@pgbackrest.org>
To: Michael Paquier <michael@paquier.xyz>, Fujii Masao <masao.fujii@gmail.com>
Cc: Nikolay Samokhvalov <nik@postgres.ai>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-02-13T00:55:15Z
Lists: pgsql-hackers 
On 2/10/26 11:52, Michael Paquier wrote:
> On Tue, Feb 10, 2026 at 12:26:36PM +0900, Fujii Masao wrote:
>> +1 to apply this change only to the master branch. Patch attached.
> 
> It looks like something we should have a test for, at least..

+1 for a test.

> +    /*
> +     *
> +     * If both signal files are present, standby signal file takes precedence.
> +     * If neither is present then we won't enter archive recovery.
> +     */
> 
> This comment's format is incorrect.

Other than the comment the patch looks good overall.

Reluctantly I have to agree to not back patch this. I'm not sure how 
this change would break existing recovery processes but experience tells 
me that it probably would.

Instead -- I wonder if we could add a warning in the back branches?

Regards,
-David

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove recovery.signal at recovery end when both signal files are present.