Horton

Re: minor refactor on src/test/modules/test_ddl_deparse/sql/alter_table.sql

Heikki Linnakangas <hlinnaka@iki.fi>

View thread
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Chao Li <li.evan.chao@gmail.com>, jian he <jian.universality@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2025-12-10T17:32:18Z
Lists: pgsql-hackers 
On 25/08/2025 04:05, Chao Li wrote:
>> On Aug 25, 2025, at 08:00, jian he <jian.universality@gmail.com> wrote:
>> in src/test/modules/test_ddl_deparse/sql/alter_table.sql:
>>
>> ----
>> The test initially focuses on the "parent" table, then switches to the 
>> "part"
>> table, and goes back to the "parent" table.
>> This seems weird?  so I slightly adjusted the order to cover the "parent"
>> table first, followed by the "part" table.
> 
> I think this change makes the test more organized.

Agreed, it looks a bit weird.

>> src/test/modules/test_ddl_deparse/sql/alter_table.sql
>> don't have ALTER TABLE ALTER COLUMN SET EXPRESSION,
>> so I added a test on it.
>> <v1-0001-refactor-test_ddl_deparse-sql-alter_table.sql.patch>
> 
> 
> I confirm “make check” passed with this patch.

Committed, thanks!

- Heikki