Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE

Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>

From: ilmari@ilmari.org (Dagfinn Ilmari Mannsåker )
To: pgsql-hackers@postgresql.org
Date: 2018-08-30T16:54:23Z
Lists: pgsql-hackers

Attachments

ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes:

> Hi hackers,
>
> I just noticed that psql's tab completion for ALTER TABLE … SET
> TABLESPACE was treating it as any other configuration parameter and
> completing with FROM DEFAULT or TO after it, instead of a list of
> tablespaces.

And just after hitting send, I noticed I'd typed ALTER TABLE instead of
ALTER DATABASE, including in the commit message :(

Fixed patch attached.

- ilmari 
-- 
"I use RMS as a guide in the same way that a boat captain would use
 a lighthouse.  It's good to know where it is, but you generally
 don't want to find yourself in the same spot." - Tollef Fog Heen

Commits

  1. Get rid of explicit argument-count markings in tab-complete.c.

  2. Fix psql's tab completion for ALTER DATABASE ... SET TABLESPACE.