Horton

Re: make -C libpq check fails obscurely if tap tests are disabled

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org
Cc: Andres Freund <andres@anarazel.de>
Date: 2022-07-20T19:00:28Z
Lists: pgsql-hackers

Attachments

On 2022-07-20 We 13:23, Justin Pryzby wrote:
> make -C ./src/interfaces/libpq check
> PATH=... && @echo "TAP tests not enabled. Try configuring with --enable-tap-tests"
> /bin/sh: 1: @echo: not found
>
> make is telling the shell to run "@echo" , rather than running "echo" silently.
>
> Since:
>
> commit 6b04abdfc5e0653542ac5d586e639185a8c61a39
> Author: Andres Freund <andres@anarazel.de>
> Date:   Sat Feb 26 16:51:47 2022 -0800
>
>     Run tap tests in src/interfaces/libpq.



Yeah. It's a bit ugly but I think the attached would fix it.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

  1. Increase minimum supported GNU make version to 3.81.

  2. Fix [install]check in interfaces/libpq/Makefile

  3. Run tap tests in src/interfaces/libpq.