Re: [POC] A better way to expand hash indexes.

Jesper Pedersen <jesper.pedersen@redhat.com>

From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Mithun Cy <mithun.cy@enterprisedb.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, David Steele <david@pgmasters.net>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-03-27T18:26:20Z
Lists: pgsql-hackers

Attachments

Hi Mithun,

On 03/26/2017 01:56 AM, Mithun Cy wrote:
> Thanks, Amit for the review.
> On Sat, Mar 25, 2017 at 7:03 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>>
>> I think one-dimensional patch has fewer places to touch, so that looks
>> better to me.  However, I think there is still hard coding and
>> assumptions in code which we should try to improve.
>
> Great!, I will continue with spares 1-dimensional improvement.
>

I ran some performance scenarios on the patch to see if the increased 
'spares' allocation had an impact. I havn't found any regressions in 
that regard.

Attached patch contains some small fixes, mainly to the documentation - 
on top of v7.

Best regards,
  Jesper

Commits

  1. Fix formula in _hash_spareindex.

  2. Expand hash indexes more gradually.

  3. Change hash indexes to store only the hash code rather than the whole indexed