Horton

Re: daitch_mokotoff module

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>, Dag Lem <dag@nimrod.no>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>, Andres Freund <andres@anarazel.de>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Paul Ramsey <pramsey@cleverelephant.ca>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-04-08T02:50:32Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Avoid using non-ASCII commentary in daitch_mokotoff.c.

  2. Remove some non-ASCII symbols from a comment.

  3. Remove useless dependencies in daitch_mokotoff_header.pl.

  4. Pacify perlcritic.

  5. Add support for Daitch-Mokotoff Soundex in contrib/fuzzystrmatch.

  6. Enable routine running of citext's UTF8-specific test cases.

On 2023-04-07 Fr 21:52, Tom Lane wrote:
> I wrote:
>> I pushed this after some mostly-cosmetic fiddling.  Most of the
>> buildfarm seems okay with it,
> Spoke too soon [1]:
>
> make[1]: Entering directory '/home/linux1/build-farm-16-pipit/buildroot/HEAD/pgsql.build/contrib/fuzzystrmatch'
> '/usr/bin/perl' daitch_mokotoff_header.pl daitch_mokotoff.h
> Can't locate open.pm in @INC (you may need to install the open module) (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at daitch_mokotoff_header.pl line 15.
> BEGIN failed--compilation aborted at daitch_mokotoff_header.pl line 15.
> make[1]: *** [Makefile:33: daitch_mokotoff.h] Error 2
>
> pipit appears to be running a reasonably current system (RHEL8), so
> the claim that "open" is a Perl core module appears false.  We need
> to rewrite this to not use that.
>
> 			regards, tom lane
>
> [1]https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pipit&dt=2023-04-08%2001%3A02%3A39
>
>

I think it is a core module (See <https://metacpan.org/pod/open>) but it 
appears that some packagers have separated it out for reasons that 
aren't entirely obvious:

andrew@emma:~ $ rpm -q -l -f /usr/share/perl5/open.pm
/usr/share/man/man3/open.3pm.gz
/usr/share/perl5/open.pm

cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com