Re: Logger process and "LOG: could not close client or listen socket: Bad file descriptor"
Heikki Linnakangas <hlinnaka@iki.fi>
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Peter Geoghegan <pg@bowt.ie>, Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-08-29T06:27:48Z
Lists: pgsql-hackers
On 29/08/2023 06:18, Peter Geoghegan wrote: > On Sun, Aug 27, 2023 at 5:52 PM Michael Paquier <michael@paquier.xyz> wrote: >> From what I can see, this is is a rather old issue, because >> ListenSocket[] is filled with PGINVALID_SOCKET *after* starting the >> syslogger. It seems to me that we should just initialize the array >> before starting the syslogger, so as we don't get these incorrect >> logs? >> >> Thoughts? Please see the attached. > > Agreed, this is very annoying. I'm going to start using your patch > with the feature branch I'm working on. Hopefully that won't be > necessary for too much longer. Just to close the loop on this thread: I committed and backpatched Michael's fix. Discussion on other thread at https://www.postgresql.org/message-id/9caed67f-f93e-5701-8c25-265a2b139ed0%40iki.fi. -- Heikki Linnakangas Neon (https://neon.tech)
Commits
-
Initialize ListenSocket array earlier.
- 0c10240600ad 15.5 landed
- 3d895f95a020 14.10 landed
- a01e479e8483 13.13 landed
- 5f38ff3d0f65 16.0 landed
- 5fec3c870ec8 17.0 landed