Re: Add reject_limit option to file_fdw
Fujii Masao <masao.fujii@oss.nttdata.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: torikoshia <torikoshia@oss.nttdata.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2024-11-11T16:49:34Z
Lists: pgsql-hackers
On 2024/11/11 21:45, torikoshia wrote: >> Thanks for adding the comment. It clearly states that REJECT_LIMIT can be >> a single-quoted string. However, it might also be helpful to mention that >> it can be provided as an int64 in the COPY command option. How about >> updating it like this? >> >> ------------------------------------ >> REJECT_LIMIT can be specified in two ways: as an int64 for the COPY command >> option or as a single-quoted string for the foreign table option using >> file_fdw. Therefore this function needs to handle both formats. >> ------------------------------------ > > Thanks! it seems better. > > > Attached v3 patch. Thanks for updating the patch! It looks like you forgot to attach it, though. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION
Commits
-
file_fdw: Add regression tests for ON_ERROR and other options.
- 631db1d4b251 18.0 landed
-
file_fdw: Add REJECT_LIMIT option to file_fdw.
- 6c8f670323d2 18.0 landed