Horton

Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

View thread View on postgr.es
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgreSQL.org
Date: 2018-10-12T16:40:42Z
Lists: pgsql-hackers 

On 10/12/2018 12:20 PM, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> I'm asking again, what exactly do we test by having these types in the
>> dump? They're bog standard types, there's nothing new for pg_dump to
>> test with them. No weird typmod rules, no weird parse-time type mapping,
>> nothing?
> That's a pretty fair point.  The types' I/O functions will be exercised
> well enough by the regression tests themselves, and it's hard to see what
> more test coverage is gained by including them in pg_dump/pg_upgrade
> testing.  Maybe we should just drop those tables and be done with it.
>

If you're happy with that then go for it. It will be less work for me ;-)

cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Clean up/tighten up coercibility checks in opr_sanity regression test.

  2. Remove abstime, reltime, tinterval tables from old regression databases.