Re: [PATCH] ANALYZE: hash-accelerate MCV tracking for equality-only types
Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
To: Chengpeng Yan <chengpeng_yan@outlook.com>
Cc: Tatsuya Kawata <kawatatatsuya0913@gmail.com>,
PostgreSQL-development <pgsql-hackers@postgresql.org>,
John Naylor <johncnaylorls@gmail.com>
Date: 2026-05-03T14:16:24Z
Lists: pgsql-hackers
Attachments
On 4/14/26 04:34, Chengpeng Yan wrote: > I split v5 accordingly. The first patch changes the singleton handling > from shifting to a cursor-based eviction scheme, and the second patch > adds the hash lookup. I reviewed v5 of the patches. Instead of going through each issue one by one, I made a pass to clean up and clarify the code and summarize the main changes belows: - Fixed a few typos in comments and added comments in places where the logic was not immediately clear; - Rewrote the bubble-up loop using `for` loop, which I find more readable. Also removed some confusing uses of the `j` variable that mase the flow harder to follow; - Simplified parts of the code to improve overall readability. -- Best regards, Ilia Evdokimov, Tantor Labs LLC, https://tantorlabs.com/