Horton

Re: psql - add SHOW_ALL_RESULTS option

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Date: 2021-02-27T15:19:30Z
Lists: pgsql-hackers

Attachments

On 30.09.20 08:21, Michael Paquier wrote:
> On Mon, Jul 20, 2020 at 07:48:42AM +0200, Fabien COELHO wrote:
>> Yes, indeed. I'm planning to investigate, hopefully this week.
> 
> This reply was two months ago, and nothing has happened, so I have
> marked the patch as RwF.

Given the ongoing work on returning multiple result sets from stored 
procedures[0], I went to dust off this patch.

Based on the feedback, I put back the titular SHOW_ALL_RESULTS option, 
but set the default to on.  I fixed the test failure in 
013_crash_restart.pl.  I also trimmed back the test changes a bit so 
that the resulting test output changes are visible better.  (We could 
make those stylistic changes separately in another patch.)  I'll put 
this back into the commitfest for another look.


[0]: 
https://www.postgresql.org/message-id/flat/6e747f98-835f-2e05-cde5-86ee444a7140@2ndquadrant.com

Commits

  1. psql: Show all query results by default

  2. psql: Refactor ProcessResult()

  3. psql: Refactor SendQuery()

  4. psql: Add test for psql behavior on server crash

  5. psql: Additional tests

  6. Improve some psql test code

  7. psql: Fix some scan-build warnings

  8. psql: Add test for handling of replication commands

  9. psql: More tests

  10. psql: Add various tests

  11. psql: Add test for query canceling

  12. Revert "psql: Show all query results by default"

  13. Extend a test case a little