Re: cataloguing NOT NULL constraints

Alexander Lakhin <exclusion@gmail.com>

From: Alexander Lakhin <exclusion@gmail.com>

To: Alvaro Herrera <alvherre@alvh.no-ip.org>, Dean Rasheed <dean.a.rasheed@gmail.com>, Peter Eisentraut <peter@eisentraut.org>

Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@lists.postgresql.org

Date: 2023-08-31T10:00:00Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Revert structural changes to not-null constraints
- 6f8bb7c1e961 17.0 landed
Fix inconsistencies in error messages
- 21ac38f498b3 17.0 landed
Disallow direct change of NO INHERIT of not-null constraints
- d45597f72fe5 17.0 landed
Disallow NO INHERIT not-null constraints on partitioned tables
- 13daa33fa5a6 17.0 landed
Better handle indirect constraint drops
- 0cd711271d42 17.0 cited
Don't try to assign smart names to constraints
- d72d32f52d26 17.0 cited
Fix restore of not-null constraints with inheritance
- d9f686a72ee9 17.0 landed
ATTACH PARTITION: Don't match a PK with a UNIQUE constraint
- cee8db3f680b 17.0 landed
Fix propagating attnotnull in multiple inheritance
- c3709100be73 17.0 landed
Check stack depth in new recursive functions
- b0f7dd915bca 17.0 landed
Move privilege check to the right place
- ac22a9545ca9 17.0 cited
Update information_schema definition for not-null constraints
- 3af721794272 17.0 landed
Fix not-null constraint test
- d0ec2ddbe088 17.0 landed
Disallow changing NO INHERIT status of a not-null constraint
- 9b581c534186 17.0 cited
Catalog not-null constraints
- b0e96f311985 17.0 cited
parallel_schedule: add comment on event_trigger test dependency
- c8e43c22be27 17.0 landed
Revert "Catalog NOT NULL constraints" and fallout
- 9ce04b50e120 16.0 landed
Adjust contrib/sepgsql regression test expected outputs.
- 76c111a7f166 16.0 landed
Fix table name clash in recently introduced test
- 728015a47016 16.0 landed
Catalog NOT NULL constraints
- e056c557aef4 16.0 landed
Change the rules for inherited CHECK constraints to be essentially the same
- cd902b331dc4 8.4.0 cited

Hi Alvaro,

25.08.2023 14:38, Alvaro Herrera wrote:
> I have now pushed this again.  Hopefully it'll stick this time.

I've found that after that commit the following query:
CREATE TABLE t(a int PRIMARY KEY) PARTITION BY RANGE (a);
CREATE TABLE tp1(a int);
ALTER TABLE t ATTACH PARTITION tp1 FOR VALUES FROM (0) to (1);

triggers a server crash:
Core was generated by `postgres: law regression [local] ALTER TABLE                                  '.
Program terminated with signal SIGSEGV, Segmentation fault.

warning: Section `.reg-xstate/2194811' in core file too small.
#0  0x0000556007711d77 in MergeAttributesIntoExisting (child_rel=0x7fc30ba309d8,
     parent_rel=0x7fc30ba33f18) at tablecmds.c:15771
15771                                   if (!((Form_pg_constraint) GETSTRUCT(contup))->connoinherit)
(gdb) bt
#0  0x0000556007711d77 in MergeAttributesIntoExisting (child_rel=0x7fc30ba309d8,
     parent_rel=0x7fc30ba33f18) at tablecmds.c:15771
#1  0x00005560077118d4 in CreateInheritance (child_rel=0x7fc30ba309d8, parent_rel=0x7fc30ba33f18)
     at tablecmds.c:15631
...

(gdb) print contup
$1 = (HeapTuple) 0x0

On b0e96f311~1 I get:
ERROR:  column "a" in child table must be marked NOT NULL

Best regards,
Alexander