Horton
Menu

Re: [PATCH] Don't block HOT update by BRIN index

Tomas Vondra <tomas.vondra@enterprisedb.com>

View thread
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Justin Pryzby <pryzby@telsasoft.com>
Cc: Josef Šimánek <josef.simanek@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, pgsql-hackers@postgresql.org
Date: 2021-12-06T00:51:47Z
Lists: pgsql-hackers 
On 12/5/21 21:16, Tom Lane wrote:
> Justin Pryzby <pryzby@telsasoft.com> writes:
>> brin.sql's new brin_hot test is failing sometimes.
>> Evidently because:
>> | 2021-12-01 04:02:01.096 CET [61a6e587.3106b1:4] LOG:  wait_for_hot_stats delayed 33.217301 seconds
>> It seems like maybe the UDP packet lost to the stats collector got lost ?
>> It fails less than 10% of the time here, probably depending on load.
> 
> Oh, geez.  *Please* let us not add another regression failure mode
> like the ones that afflict stats.sql.  We do not need a doubling
> of that failure rate.  I suggest just removing this test.
> 

Whooops. Agreed, I'll get rid of that test.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Ignore BRIN indexes when checking for HOT updates

  2. Move test for BRIN HOT behavior to stats.sql

  3. Ignore BRIN indexes when checking for HOT udpates