Generate pg_stat_get_* functions with Macros
Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-11-22T07:09:22Z
Lists: pgsql-hackers
Attachments
- v1-0001-PGSTAT_DEFINE_REL_FIELD_ACCESSOR.patch (text/plain) patch v1-0001
Hi hackers, Please find attached a patch proposal to $SUBJECT. The idea has been proposed by Andres in [1] and can be seen as preparatory work for [1]. The patch introduces 2 new Macros, PGSTAT_DEFINE_REL_INT64_FIELD_ACCESSOR and PGSTAT_DEFINE_REL_TSTZ_FIELD_ACCESSOR. For some functions (namely pg_stat_get_ins_since_vacuum(), pg_stat_get_dead_tuples(), pg_stat_get_mod_since_analyze(), pg_stat_get_live_tuples(), pg_stat_get_last_autovacuum_time(), pg_stat_get_autovacuum_count(), pg_stat_get_last_vacuum_time(), pg_stat_get_last_autoanalyze_time(), pg_stat_get_autoanalyze_count() and pg_stat_get_last_analyze_time()), I had to choose between renaming the function and the counter. I took the later option to avoid changing the linked views, tests.... This patch is also a step forward to "cleaning" the metrics/fields/functions naming (means having them match). [1]: https://www.postgresql.org/message-id/flat/f572abe7-a1bb-e13b-48c7-2ca150546822@gmail.com Looking forward to your feedback, Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
Commits
-
Fix macro definitions in pgstatfuncs.c
- 66dcb09246b4 16.0 landed
-
Generate pg_stat_get*() functions for databases using macros
- 8018ffbf5895 16.0 landed