Re: Support custom socket directory in pg_upgrade

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

To: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@2ndquadrant.com>

Cc: Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2018-11-30T18:24:07Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add a --socketdir option to pg_upgrade.
- 2d34ad843031 12.0 landed

On 30/11/2018 17:58, Tom Lane wrote:
> So we seem to be at an impasse here.  By my count, three people have
> expressed support for the patch's approach of adding a socket-directory
> option, while two people seem to prefer the idea of putting pg_upgrade's
> socket under /tmp (possibly with a way to override that).  That's not
> enough of a consensus to proceed with either approach, really, but
> we ought to do something because the problem is real.
> 
> Given that we have a patch for this approach, and no patch has been
> offered for the /tmp approach, I'm kind of inclined to exercise
> committer's discretion and proceed with this patch.  Will anybody
> be seriously annoyed if I do?

I think it's fair to proceed and leave open that someone submits a
(possibly) better patch for a different approach in the future.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services