Horton

Re: WIP: Aggregation push-down

David Steele <david@pgmasters.net>

View thread View on postgr.es
From: David Steele <david@pgmasters.net>
To: Laurenz Albe <laurenz.albe@cybertec.at>, Antonin Houska <ah@cybertec.at>, Tom Lane <tgl@sss.pgh.pa.us>, Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Andy Fan <zhihui.fan1213@gmail.com>, legrand legrand <legrand_legrand@hotmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Daniel Gustafsson <daniel@yesql.se>
Date: 2021-03-03T16:42:05Z
Lists: pgsql-hackers 
On 7/3/20 6:07 AM, Laurenz Albe wrote:
> On Thu, 2020-07-02 at 14:39 +0200, Daniel Gustafsson wrote:
>> This version now fails to apply to HEAD, with what looks like like a trivial
>> error in the expected test output.  Can you please submit a rebased version so
>> we can see it run in the patch tester CI?  I'm marking the entry as Waiting on
>> Author in the meantime.
> 
> I have rebased the patch against current HEAD, it passes "make installcheck".

This needs another rebase so marked as Waiting on Author: 
http://cfbot.cputube.org/patch_32_1247.log

As far as I can see reviewer concerns have been addressed as they have 
come up, but as Tomas noted this is a bit of a niche feature as far as 
who might commit it.

Tom, Tomas, would you care to share your remaining concerns, if any?

Regards,
-- 
-David
david@pgmasters.net

Commits

  1. Move estimate_hashagg_tablesize to selfuncs.c, and widen result to double.

  2. Remove unnecessairly duplicated gram.y productions