Horton

Re: fairywren is generating bogus BASE_BACKUP commands

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Thomas Munro <thomas.munro@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-02-15T15:12:35Z
Lists: pgsql-hackers 
On 2/14/22 18:02, Andres Freund wrote:
> Hi,
>
> On 2022-02-14 17:32:11 -0500, Andrew Dunstan wrote:
>> About the only thing missing in your recipe is this:
> Re requiring out-of-tree builds: Thomas on IM noted that there's the
> NoDefaultCurrentDirectoryInExePath environment variable. That should avoid the
> problem leading to requiring out-of-tree builds. But I've not tested it.


Good to know.


>
>
>> # force ucrt64 prove to use the ucrt64 perl rather than whatever is in
>> the path
>> sed -i 's,^#!perl,#!/ucrt64/bin/perl,' /ucrt64/bin/core_perl/prove
>>
>>
>> Given that, you don't need to set PERL, and configure can find the perl
>> to build against from the PATH.
> That shouldn't even be needed from what I understand now. If correctly started
> the msys shell shoul dhave the right perl in path?



FSVO "the right perl". However, jacana is building against a separate
installation of AS perl, and I was trying to preserve that.


For a buildfarm animal, there is one extra package that is needed:


perl-LWP-Protocol-https


cheers


andrew



--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

  1. Remove PostgreSQL::Test::Utils::perl2host completely

  2. Unbreak pg_basebackup/t/010_pg_basebackup.pl on msys

  3. On Windows, also call shutdown() while closing the client socket.

  4. On Windows, close the client socket explicitly during backend shutdown.