Disconnect if socket cannot be put into non-blocking mode
Heikki Linnakangas <hlinnaka@iki.fi>
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-03-11T14:44:32Z
Lists: pgsql-hackers
Attachments
- 0001-Disconnect-if-socket-cannot-be-put-into-non-blocking.patch (text/x-patch) patch 0001
While self-reviewing my "Refactoring backend fork+exec code" patches, I
noticed this in pq_init():
> /*
> * In backends (as soon as forked) we operate the underlying socket in
> * nonblocking mode and use latches to implement blocking semantics if
> * needed. That allows us to provide safely interruptible reads and
> * writes.
> *
> * Use COMMERROR on failure, because ERROR would try to send the error to
> * the client, which might require changing the mode again, leading to
> * infinite recursion.
> */
> #ifndef WIN32
> if (!pg_set_noblock(MyProcPort->sock))
> ereport(COMMERROR,
> (errmsg("could not set socket to nonblocking mode: %m")));
> #endif
>
> #ifndef WIN32
>
> /* Don't give the socket to any subprograms we execute. */
> if (fcntl(MyProcPort->sock, F_SETFD, FD_CLOEXEC) < 0)
> elog(FATAL, "fcntl(F_SETFD) failed on socket: %m");
> #endif
Using COMMERROR here seems bogus. Firstly, if there was a problem with
recursion, surely the elog(FATAL) that follows would also be wrong. But
more seriously, it's not cool to continue using the connection as if
everything is OK, if we fail to put it into non-blocking mode. We should
disconnect. (COMMERROR merely logs the error, it does not bail out like
ERROR does)
Barring objections, I'll commit and backpatch the attached to fix that.
--
Heikki Linnakangas
Neon (https://neon.tech)
Commits
-
Disconnect if socket cannot be put into non-blocking mode
- df27d76d32f2 12.19 landed
- ad5cd55e675c 13.15 landed
- bf1f593e899e 14.12 landed
- 4fce5f970d58 15.7 landed
- 539e328b1c3a 16.3 landed
- f8c5317d0015 17.0 landed