Re: ORDER BY pushdowns seem broken in postgres_fdw

David Zhang <david.zhang@highgo.ca>

From: David Zhang <david.zhang@highgo.ca>
To: Ronan Dunklau <ronan@dunklau.fr>, pgsql-hackers@lists.postgresql.org
Date: 2021-09-10T21:23:48Z
Lists: pgsql-hackers
On 2021-09-06 1:16 a.m., Ronan Dunklau wrote:
> Le vendredi 3 septembre 2021, 22:54:25 CEST David Zhang a écrit :
>> The following review has been posted through the commitfest application:
>> make installcheck-world:  tested, failed
>> Implements feature:       tested, passed
>> Spec compliant:           not tested
>> Documentation:            not tested
>>
>> Applied the v6 patch to master branch and ran regression test for contrib,
>> the result was "All tests successful."
> What kind of error did you get running make installcheck-world ? If it passed
> the make check for contrib, I can't see why it would fail running make
> installcheck-world.
Just to clarify, the error I encountered was not related with patch v6, 
it was related with other extensions.
> In any case, I just checked and running make installcheck-world doesn't
> produce any error.
>
> Since HEAD had moved a bit since the last version, I rebased the patch,
> resulting in the attached v7.
>
> Best regards,
>
> --
> Ronan Dunklau
-- 
David

Software Engineer
Highgo Software Inc. (Canada)
www.highgo.ca



Commits

  1. Fix postgres_fdw to check shippability of sort clauses properly.

  2. postgres_fdw: Add ORDER BY to some remote SQL queries.