Horton

Thread

Commits

  1. C comment: add description of root_tuple_slot

  1. description of root_tuple_slot missing

    Amit Langote <langote_amit_f8@lab.ntt.co.jp> — 2018-04-23T05:50:10Z

    I noticed that the description of root_tuple_slot member is missing in the
comment above PartitionTupleRouting definition.  See if the attached patch
fixes it correctly.

Thanks,
Amit

  2. Re: description of root_tuple_slot missing

    Bruce Momjian <bruce@momjian.us> — 2018-04-26T18:54:56Z

    On Mon, Apr 23, 2018 at 02:50:10PM +0900, Amit Langote wrote:
> I noticed that the description of root_tuple_slot member is missing in the
> comment above PartitionTupleRouting definition.  See if the attached patch
> fixes it correctly.
> 
> Thanks,
> Amit

> diff --git a/src/include/executor/execPartition.h b/src/include/executor/execPartition.h
> index e81bdc4a0a..7f2b66a206 100644
> --- a/src/include/executor/execPartition.h
> +++ b/src/include/executor/execPartition.h
> @@ -90,6 +90,10 @@ typedef struct PartitionDispatchData *PartitionDispatch;
>   *								given leaf partition's rowtype after that
>   *								partition is chosen for insertion by
>   *								tuple-routing.
> + * root_tuple_slot				TupleTableSlot to be used to transiently hold
> + *								copy of a tuple that's being moved across
> + *								partitions in the root partitioned table's
> + *								rowtype
>   *-----------------------
>   */
>  typedef struct PartitionTupleRouting

Patch applied.  Thanks.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +

  3. Re: description of root_tuple_slot missing

    Amit Langote <langote_amit_f8@lab.ntt.co.jp> — 2018-04-27T00:32:39Z

    On 2018/04/27 3:54, Bruce Momjian wrote:
> On Mon, Apr 23, 2018 at 02:50:10PM +0900, Amit Langote wrote:
>> I noticed that the description of root_tuple_slot member is missing in the
>> comment above PartitionTupleRouting definition.  See if the attached patch
>> fixes it correctly.
> 
> Patch applied.  Thanks.

Thank you.

Regards,
Amit