Horton

Re: Proper object locking for GRANT/REVOKE

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Heikki Linnakangas <hlinnaka@iki.fi>, Nathan Bossart <nathandbossart@gmail.com>, Noah Misch <noah@leadboat.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-08-27T16:54:33Z
Lists: pgsql-hackers 
On 26.08.25 18:21, Heikki Linnakangas wrote:
> +1 for the comment patch (0001-Improve-objectNamesToOids-comment.patch).
> 
> +1 for also doing something like (0002-WIP-Attempt-to-put-back-intra- 
> grant-inplace.spec-cov.patch), to keep the test coverage for the "cache 
> lookup failed" error. Maybe add a new test for that, given that it's 
> pretty hacky.
> 
> Those are just comment and test updates, however, so they should not 
> block the release. I will remove this from the Open Items list.

I have committed these two patches now.

Commits

  1. Put back intra-grant-inplace.spec test coverage

  2. Improve objectNamesToOids() comment

  3. Proper object locking for GRANT/REVOKE

  4. Add an assertion in get_object_address()