Horton

Re: GiST operator class for bool

Tomas Vondra <tomas.vondra@enterprisedb.com>

View thread View on postgr.es
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>, emre@hasegeli.com, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-11-07T19:53:21Z
Lists: pgsql-hackers

Attachments

Hi,

On 11/7/21 17:44, Tom Lane wrote:
> Tomas Vondra <tomas.vondra@enterprisedb.com> writes:
>> Pushed, after adding some simple EXPLAIN to the regression test.
> 
> skink is reporting that this has some valgrind issues [1].
> I suspect sloppy conversion between bool and Datum, but
> didn't go looking.
> 

It's actually a bit worse than that :-( The opclass is somewhat confused 
about the type it should use for storage. The gbtree_ninfo struct says 
it's using gbtreekey4, the SQL script claims the params are gbtreekey8, 
and it should actually use gbtreekey2. Sorry for not noticing that.

The attached patch fixes the valgrind error for me.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Add bool to btree_gist documentation

  2. Fix gist_bool_ops to use gbtreekey2

  3. Add bool GiST opclass to btree_gist