Horton

Re: Add missing tab completion for ALTER TABLE ADD COLUMN IF NOT EXISTS

Tomas Vondra <tomas@vondra.me>

View thread View on postgr.es
From: Tomas Vondra <tomas@vondra.me>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: Karina Litskevich <litskevichkarina@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-12-16T16:40:59Z
Lists: pgsql-hackers 
On 12/8/24 05:22, Kirill Reshke wrote:
> On Sun, 8 Dec 2024 at 03:35, Tomas Vondra <tomas@vondra.me> wrote:
>>
>> Hi,
>> I took a quick look at this patch series, and it looks generally fine to
>> me. Barring objections, I'll get it committed. Yes, there's a couple
>> cosmetic details, and it needs a pgindent run, but I think I can take
>> care of that ...
>>
> Thank you for taking a look.
> 
> PFA v6 with last Karina's review comments addressed.
> 

Thanks. Pushed.

I went through the patches, and pushed them with some pretty minor
tweaks. Most of the work was about writing the commit messages. I
considered squashing the commits, but decided not to do that - each of
the 4 patches does tab completion for different command.


regards

-- 
Tomas Vondra

Commits

  1. psql: Tab completion for CREATE MATERIALIZED VIEW ... USING

  2. psql: Tab completion for CREATE TEMP TABLE ... USING

  3. psql: Tab completion for ALTER TYPE ... CASCADE/RESTRICT

  4. psql: Tab completion for ALTER TYPE ... ADD ATTRIBUTE

  5. Add more tab completion for CREATE TABLE in psql