Horton

Re: Add --check option to pgindent

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>, Tristan Partin <tristan@neon.tech>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Tom Lane <tgl@sss.pgh.pa.us>, Euler Taveira <euler@eulerto.com>, Michael Banck <mbanck@gmx.net>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2023-12-20T22:38:40Z
Lists: pgsql-hackers 
On 2023-12-20 We 11:05, Andrew Dunstan wrote:
>
> On 2023-12-19 Tu 08:57, Daniel Gustafsson wrote:
>>   The posted v5 seems like a good compromise
>> I reckon.
>>
>> Andrew: When applying this, how do we synchronize with the buildfarm 
>> to avoid
>> false negatives due to the BF using the wrong options?
>
>
> The only buildfarm animal involved here is koel, which I run, so the 
> simplest way will be for me to commit the core patch and adjust the 
> buildfarm code at the same time.
>
>

V5 seems to be the consensus. I went with that, but added in logic to 
exit the loop early for --check if we're not also doing --diff.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

  1. Rename pgindent options