Horton

Re: verify_heapam for sequences?

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-08-30T08:22:52Z
Lists: pgsql-hackers 
On 26.08.21 21:02, Mark Dilger wrote:
> I understand that sequences are really just heap tables, and since we already test corrupted heap tables, we could assume that we already have sufficient coverage.  I'm not entirely comfortable with that, though, because future patch authors who modify how tables or sequences work are not necessarily going to think carefully about whether their modifications invalidate that assumption.

Well, if we enabled verify_heapam to check sequences, and then someone 
were to change the sequence storage, a test that currently reports no 
corruption would probably report corruption then?

Commits

  1. Support amcheck of sequences