Horton

Re: base backup client as auxiliary backend process

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, Sergei Kornilov <sk@zsrv.org>, Michael Paquier <michael@paquier.xyz>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-02-22T15:12:27Z
Lists: pgsql-hackers 
On 2020-02-17 18:42, Peter Eisentraut wrote:
> On 2020-02-03 13:47, Andres Freund wrote:
>> Comment:
>>
>> - It'd be good to split out the feature independent refactorings, like
>>     the introduction of InitControlFile(), into their own commit. Right
>>     now it's hard to separate out what should just should be moved code,
>>     and what should be behavioural changes. Especially when there's stuff
>>     like just reindenting comments as part of the patch.
> 
> Agreed.  Here are three refactoring patches extracted that seem useful
> on their own.

These have been committed.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Factor out InitControlFile() from BootStrapXLOG()

  2. Reformat code comment

  3. pg_resetwal: Rename function to avoid potential conflict

  4. Expose PQbackendPID() through walreceiver API

  5. walreceiver uses a temporary replication slot by default

  6. Make lsn argument of walrcv_create_slot() optional

  7. More precise errors from initial pg_control check