Re: Bug in ExecModifyTable function and trigger issues for foreign tables

Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>

From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>, Dilip Kumar <dilipbalaut@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>
Date: 2017-06-30T09:44:02Z
Lists: pgsql-hackers
On 2017/06/16 21:29, Etsuro Fujita wrote:
> On 2017/06/16 19:26, Ashutosh Bapat wrote:

>> That issue has not been addressed. The reason stated was that it would
>> make code complicated. But I have not had chance to look at how
>> complicated would be and assess myself whether that's worth the
>> trouble.
> I have to admit that what I proposed upthread is a quick-and-dirty 
> kluge.  One thing I thought to address your concern was to move 
> rewriteTargetListUD entirely from the rewriter to the planner when doing 
> inherited UPDATE/DELETE, but I'm not sure that's a good idea, because at 
> least I think that would need a lot more changes to the rewriter.

I'll have second thought about this, so I'll mark this as waiting on author.

Best regards,
Etsuro Fujita



Commits

  1. Fix creation of resjunk tlist entries for inherited mixed UPDATE/DELETE.