Re: Declarative partitioning - another take

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>

To: Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>

Cc: Robert Haas <robertmhaas@gmail.com>, Amit Langote <amitlangote09@gmail.com>, Dmitry Ivanov <d.ivanov@postgrespro.ru>, Michael Paquier <michael.paquier@gmail.com>, Andres Freund <andres@anarazel.de>, Erik Rijkers <er@xs4all.nl>, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, Pg Hackers <pgsql-hackers@postgresql.org>, pgsql-hackers-owner@postgresql.org

Date: 2016-12-27T09:54:46Z

Lists: pgsql-hackers

Attachments

fix-wrong-ecxt_scantuple-crash.patch (text/x-diff) patch

On 2016/12/27 18:30, Rajkumar Raghuwanshi wrote:
> Hi Amit,
> 
> I have pulled latest sources from git and tried to create multi-level
> partition,  getting a server crash, below are steps to reproduce. please
> check if it is reproducible in your machine also.
> 

[ ... ]

> postgres=# INSERT INTO test_ml SELECT i, i, to_char(i, 'FM0000') FROM
> generate_series(0, 599, 2) i;
> server closed the connection unexpectedly
>     This probably means the server terminated abnormally
>     before or while processing the request.
> The connection to the server was lost. Attempting reset: Failed.

Thanks for the example.  Looks like there was an oversight in my patch
that got committed as 2ac3ef7a01 [1].

Attached patch should fix the same.

Thanks,
Amit

[1]
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=2ac3ef7a01df859c62d0a02333b646d65eaec5ff

Commits

Fix typo.
- 03bf59676ea0 10.0 landed
Document trigger-firing behavior for inheritance/partitioning.
- e17628145ac3 10.0 landed
Fire per-statement triggers on partitioned tables.
- e180c8aa8caf 10.0 landed
Set ecxt_scantuple correctly for tuple routing.
- 132488bfee68 10.0 landed
Fix interaction of partitioned tables with BulkInsertState.
- b1ecb9b3fcfb 10.0 landed
Avoid core dump for empty prepared statement in an aborted transaction.
- ba61a04bc7fe 10.0 cited
Fix some problems in check_new_partition_bound().
- 8a8afe2f54c2 10.0 landed
Remove unnecessary arguments from partitioning functions.
- 18fc5192a631 10.0 cited
Fix reporting of constraint violations for table partitioning.
- f1b4c771ea74 10.0 cited
Fix tuple routing in cases where tuple descriptors don't match.
- 2ac3ef7a01df 10.0 cited
Invalid parent's relcache after CREATE TABLE .. PARTITION OF.
- 7cd0fd655d68 10.0 landed
Doc: improve documentation about inheritance.
- 162477a63d3c 10.0 cited