Horton

Re: Fix for FETCH FIRST syntax problems

Vik Fearing <vik.fearing@2ndquadrant.com>

View thread View on postgr.es
From: Vik Fearing <vik.fearing@2ndquadrant.com>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>, pgsql-hackers@postgresql.org
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>
Date: 2018-05-20T13:38:50Z
Lists: pgsql-hackers 
On 20/05/18 05:25, Andrew Gierth wrote:
> +select_fetch_first_value:
> +			c_expr									{ $$ = $1; }
> +			| '+' I_or_F_const
> +				{ $$ = (Node *) makeSimpleA_Expr(AEXPR_OP, "+", NULL, $2, @1); }
> +			| '-' I_or_F_const
> +				{ $$ = doNegate($2, @1); }

I think there should be a comment for why you're accepting FCONST when
the value has to be integral.
-- 
Vik Fearing                                          +33 6 46 75 15 36
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support

Commits

  1. Fix SQL:2008 FETCH FIRST syntax to allow parameters.

  2. SQL:2008 alternative syntax for LIMIT/OFFSET: