Re: [Proposal] Add foreign-server health checks infrastructure

Fujii Masao <masao.fujii@oss.nttdata.com>

From: Fujii Masao <masao.fujii@oss.nttdata.com>

To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>

Cc: Katsuragi Yuta <katsuragiy@oss.nttdata.com>, vignesh C <vignesh21@gmail.com>, Ted Yu <yuzhihong@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Önder Kalacı <onderkalaci@gmail.com>, "Shinya11.Kato@oss.nttdata.com" <Shinya11.Kato@oss.nttdata.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, 'Shubham Khanna' <khannashubham1197@gmail.com>

Date: 2024-07-25T18:41:53Z

Lists: pgsql-hackers

Attachments

v43-0001-doc-Enhance-documentation-for-postgres_fdw_get_c.patch (text/plain) patch v43-0001
v43-0002-postgres_fdw-Add-used_in_xact-column-to-postgres.patch (text/plain) patch v43-0002
v43-0003-postgres_fdw-Add-connection-status-check-to-post.patch (text/plain) patch v43-0003


On 2024/07/24 20:40, Hayato Kuroda (Fujitsu) wrote:
> Attached patches contain above fixes and comment improvements per request from GPT-4o.

Thanks for updating the patches!

I’ve created a new base patch and split the v42-0001 patch into two parts
to implement the feature and improvements step by step. After pushing these
patches, I’ll focus on the v42-0002 patch next.

I’ve attached the three patches.

v43-0001:
This new patch enhances documentation for postgres_fdw_get_connections()
output columns. The output columns were documented in text format,
which is manageable for the current two columns. However, upcoming patches
will add new columns, making text descriptions less readable.
This patch updates the documentation to use a table format,
making it easier for users to understand each output column.

v43-0002:
This patch adds the "used_in_xact" column to postgres_fdw_get_connections().
It separates this change from the original v42-0001 patch for clarity.

v43-0003
This patch adds the "closed" column to postgres_fdw_get_connections().

I’ve also made several code improvements, for example adding a typedef for
pgfdwVersion to simplify its usage, and updated typedefs.list.

+enum pgfdwVersion
+{
+	PGFDW_V1_0 = 0,
+	PGFDW_V1_2,
+}			pgfdwVersion;

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

postgres_fdw: Extend postgres_fdw_get_connections to return user name.
- 4f08ab554577 18.0 landed
postgres_fdw: Fix bug in connection status check.
- 454aab4b738e 18.0 landed
postgres_fdw: Add connection status check to postgres_fdw_get_connections().
- 857df3cef7be 18.0 landed
postgres_fdw: Add "used_in_xact" column to postgres_fdw_get_connections().
- c297a47c5f8d 18.0 landed
doc: Enhance documentation for postgres_fdw_get_connections() output columns.
- 284c030a10b8 18.0 landed
Avoid reference to nonexistent array element in ExecInitAgg().
- 92957ed98c5c 16.0 cited
Add WL_SOCKET_CLOSED for socket shutdown events.
- 50e570a59e7f 15.0 cited
postgres_fdw: reestablish new connection if cached one is detected as broken.
- 32a9c0bdf493 14.0 cited