Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

Alexey Kondratov <a.kondratov@postgrespro.ru>

From: Alexey Kondratov <a.kondratov@postgrespro.ru>

To: Alvaro Herrera <alvherre@2ndquadrant.com>, Andres Freund <andres@anarazel.de>

Cc: Andrey Borodin <x4mmm@yandex-team.ru>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Dmitry Dolgov <9erthalion6@gmail.com>, Michael Paquier <michael@paquier.xyz>, vladimirlesk@yandex-team.ru, dsarafan@yandex-team.ru

Date: 2019-02-20T12:06:11Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Move frontend-side archive APIs from src/common/ to src/fe_utils/
- 8d8b89266ca0 13.0 landed
- a3b2bf1fe7ce 14.0 landed
Add -c/--restore-target-wal to pg_rewind
- a7e8ece41cf7 13.0 landed
Move routine definitions of xlogarchive.c to a new header file
- 616ae3d2b056 13.0 landed
Move routine building restore_command to src/common/
- e09ad07b21a2 13.0 landed
Integrate recovery.conf into postgresql.conf
- 2dedf4d9a899 12.0 cited

Attachments

v4-0001-pg_rewind-options-to-use-restore_command.patch (text/x-patch)

Hi,

>
> I will work out this one with postgres -C and come back till the next 
> commitfest. I found that something similar is already used in pg_ctl 
> and there is a mechanism for finding valid executables in exec.c. So 
> it does not seem to be a big deal at the first sight.
>

I have reworked the patch, please find new version attached. It is 3 
times as smaller than the previous one and now touches pg_rewind's code 
only. Tests are also slightly refactored in order to remove duplicated 
code. Execution of postgres -C is used for restore_command retrieval (if 
-r is passed) as being suggested. Otherwise everything works as before.

Andres, Alvaro does it make sense now?



Regards

-- 
Alexey Kondratov

Postgres Professional https://www.postgrespro.com
Russian Postgres Company