Horton

Re: btree_gin and btree_gist for enums

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

View thread View on postgr.es
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-02-25T18:39:31Z
Lists: pgsql-hackers 

On 02/25/2017 01:34 PM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> On 02/25/2017 12:04 PM, Tom Lane wrote:
>>> I think it'd be better to leave DirectFunctionCallN alone and just invent
>>> a small number of CallerFInfoFunctionCallN support functions (maybe N=1
>>> and N=2 would be enough, at least for now).
>> See attached.
> Yeah, I like this better, except that instead of
>
> + * The callee should not look at anything except the fn_mcxt and fn_extra.
> + * Anything else is likely to be bogus.
>
> maybe
>
> + * It's recommended that the callee only use the fn_extra and fn_mcxt
> + * fields, as other fields will typically describe the calling function
> + * not the callee.  Conversely, the calling function should not have
> + * used fn_extra, unless its use is known compatible with the callee's.
>
> 			


OK, Works for me. Thanks.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Add btree_gin support for enum types

  2. Add btree_gist support for enum types.

  3. Use CallerFInfoFunctionCall with btree_gist for numeric types

  4. Add a direct function call mechanism using the caller's context.

  5. Add support for EUI-64 MAC addresses as macaddr8

  6. Add an Assert that enum_cmp_internal() gets passed an FmgrInfo pointer.