Re: [PATCH v2] use has_privs_for_role for predefined roles

Joe Conway <mail@joeconway.com>

From: Joe Conway <mail@joeconway.com>
To: Joshua Brindle <joshua.brindle@crunchydata.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: "Bossart, Nathan" <bossartn@amazon.com>, Stephen Frost <sfrost@snowman.net>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2022-02-06T16:38:26Z
Lists: pgsql-hackers
On 1/4/22 16:51, Joshua Brindle wrote:
> On Tue, Jan 4, 2022 at 3:56 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>
>> "Bossart, Nathan" <bossartn@amazon.com> writes:
>> > On 11/12/21, 12:34 PM, "Joshua Brindle" <joshua.brindle@crunchydata.com> wrote:
>> >> All of these and also adminpack.sgml updated. I think that is all of
>> >> them but docs broken across lines and irregular wording makes it
>> >> difficult.
>>
>> > LGTM.  I've marked this as ready-for-committer.
>>
>> This needs another rebase --- it's trying to adjust
>> file_fdw/output/file_fdw.source, which no longer exists
>> (fix the regular file_fdw.out, instead).
>>
>>                         regards, tom lane
> 
> Attached, thanks

I'd like to pick this patch up and see it through to commit/push. 
Presumably that will include back-patching to all supported pg versions.

Before I go through the effort to back-patch, does anyone want to argue 
that this should *not* be back-patched?

Thanks,

Joe
-- 
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development



Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Fix a bug in roles_is_member_of.

  2. docs: Fix up some out-of-date references to INHERIT/NOINHERIT.

  3. Allow grant-level control of role inheritance behavior.

  4. Make role grant system more consistent with other privileges.

  5. Document basebackup_to_shell.required_role.