Horton

Re: New GUC to sample log queries

Adrien NAYRAT <adrien.nayrat@anayrat.info>

View thread View on postgr.es
From: Adrien Nayrat <adrien.nayrat@anayrat.info>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>, Dmitry Dolgov <9erthalion6@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, <vik.fearing@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, "Michael Paquier" <michael@paquier.xyz>, David Rowley <david.rowley@2ndquadrant.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-11-29T21:09:10Z
Lists: pgsql-hackers

Attachments

On 11/29/18 6:35 PM, Alvaro Herrera wrote:
> 
> Sounds good to me (we -> you, I suppose?).  I'd tweak the extra_desc for
> log_min_duration_statement too, because we no longer log "all" when the
> rate is <1; maybe "Zero prints all queries, subject to
> log_statement_sample_rate.  -1 turns this feature off."

Right, I also changed a part of log_min_duration_statement documentation to
mention log_statement_sample_rate

> 
> I just noticed we don't use "you" anywhere in the descs, except for this
> one:

Maybe we could change with something like this :

long_desc: "Take a value between 0 (never log) and 1.0 (always log) to log a
sample."


Thanks,

Commits

  1. Use pg_strong_random() to select each server process's random seed.

  2. Use a separate random seed for SQL random()/setseed() functions.

  3. Marginal performance hacking in erand48.c.

  4. Fix latent problem with pg_jrand48().

  5. Silence compiler warning

  6. Add log_statement_sample_rate parameter