Horton

Re: New GUC to sample log queries

Tomas Vondra <tomas.vondra@2ndquadrant.com>

View thread View on postgr.es
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>, Vik Fearing <vik.fearing@2ndquadrant.com>
Cc: Adrien Nayrat <adrien.nayrat@anayrat.info>, Michael Paquier <michael@paquier.xyz>, David Rowley <david.rowley@2ndquadrant.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2018-07-16T21:06:44Z
Lists: pgsql-hackers 
On 07/16/2018 05:24 PM, Robert Haas wrote:
> On Sun, Jul 15, 2018 at 6:53 AM, Vik Fearing
> <vik.fearing@2ndquadrant.com> wrote:
>> Hmm.  Not sure if that last word should be _sample, _sampling, _rate, or
>> a combination of those.
> 
> +1 for rate or sample_rate.  I think "sample" or "sampling" without
> "rate" will not be very clear.
> 

1+ to sample_rate

It's what auto_explain and pgbench uses, so let's keep the naming
consistent.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Use pg_strong_random() to select each server process's random seed.

  2. Use a separate random seed for SQL random()/setseed() functions.

  3. Marginal performance hacking in erand48.c.

  4. Fix latent problem with pg_jrand48().

  5. Silence compiler warning

  6. Add log_statement_sample_rate parameter