Horton

Re: TAP test for recovery_end_command

Euler Taveira <euler@eulerto.com>

View thread View on postgr.es
From: "Euler Taveira" <euler@eulerto.com>
To: "Amul Sul" <sulamul@gmail.com>, "PostgreSQL Hackers" <pgsql-hackers@lists.postgresql.org>
Date: 2021-09-13T00:25:32Z
Lists: pgsql-hackers 
On Thu, Sep 9, 2021, at 8:18 AM, Amul Sul wrote:
> The attached patch adds a small test for recovery_end_command execution.
Additional coverage is always a good thing.

> Currently, patch tests execution of recovery_end_command by creating
> dummy file, I am not wedded only to this approach, other suggestions
> also welcome.
This test file is for archiving only. It seems 020_archive_status.pl is more
appropriate for testing this parameter.

> Also, we don't have a good test for archive_cleanup_command as well, I
> am not sure how we could test that which executes with every
> restart-point.
Setup a replica and stop it. It triggers a restartpoint during the shutdown.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

Commits

  1. Add TAP test for archive_cleanup_command and recovery_end_command