Horton

Thread

Commits

  1. Fix comment related to calculation location of total_table_pages

  2. Postpone calculating total_table_pages until after pruning/exclusion.

  1. obsolete comment above index_pages_fetched

    Amit Langote <langote_amit_f8@lab.ntt.co.jp> — 2019-02-13T04:57:09Z

    Hi,

I think the following commit:

commit c6e4133fae1fde93769197379ffcc2b379845113
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date:   Wed Nov 7 12:12:56 2018 -0500

    Postpone calculating total_table_pages until after pruning/exclusion.
...


obsoleted a sentence in the comment above index_pages_fetched(), which says:

 * "index_pages" is the amount to add to the total table space, which was
 * computed for us by query_planner.

total_table_pages is computed by make_one_rel as of the aforementioned
commit.  Attached fixes this.

Thanks,
Amit

  2. Re: obsolete comment above index_pages_fetched

    Michael Paquier <michael@paquier.xyz> — 2019-02-13T07:33:35Z

    On Wed, Feb 13, 2019 at 01:57:09PM +0900, Amit Langote wrote:
> total_table_pages is computed by make_one_rel as of the aforementioned
> commit.  Attached fixes this.

Thanks, fixed.
--
Michael

  3. Re: obsolete comment above index_pages_fetched

    Amit Langote <langote_amit_f8@lab.ntt.co.jp> — 2019-02-13T07:41:01Z

    On 2019/02/13 16:33, Michael Paquier wrote:
> On Wed, Feb 13, 2019 at 01:57:09PM +0900, Amit Langote wrote:
>> total_table_pages is computed by make_one_rel as of the aforementioned
>> commit.  Attached fixes this.
> 
> Thanks, fixed.

Thank you.

Regards,
Amit