Horton

Re: Fdw batch insert error out when set batch_size > 65535

Tomas Vondra <tomas.vondra@enterprisedb.com>

View thread View on postgr.es
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-07-03T16:48:14Z
Lists: pgsql-hackers 
On 7/2/23 15:50, Tomas Vondra wrote:
> On 7/2/23 15:23, Tom Lane wrote:
>> Andres Freund <andres@anarazel.de> writes:
>>> On 2021-06-11 18:44:28 -0400, Tom Lane wrote:
>>>> I suggest what we do is leave it in place for long enough to get
>>>> a round of reports from those slow animals, and then (assuming
>>>> those reports are positive) drop the test.
>>
>>> I think two years later is long enough to have some confidence in this being
>>> fixed?
>>
>> +1, time to drop it (in the back branches too).
>>
> 
> OK, will do (unless someone else wants to handle this) on Monday.
> 

FWIW I've removed the test from all branches where it was present.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Remove expensive test of postgres_fdw batch inserts

  2. Adjust batch size in postgres_fdw to not use too many parameters

  3. Implement support for bulk inserts in postgres_fdw