Re: unicode test programs don't build with meson
Peter Eisentraut <peter@eisentraut.org>
From: Peter Eisentraut <peter@eisentraut.org>
To: Aleksander Alekseev <aleksander@timescale.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-10-30T07:32:05Z
Lists: pgsql-hackers
On 18.10.24 15:17, Aleksander Alekseev wrote:
>> 1) Add libintl directly to the affected programs, like
>>
>> case_test = executable('case_test',
>> ['case_test.c'],
>> - dependencies: [frontend_port_code, icu],
>> + dependencies: [frontend_port_code, icu, libintl],
>> include_directories: inc,
>> link_with: [common_static, pgport_static],
>> build_by_default: false,
>
> To me the first option seems to be the most natural one (does the
> program depend on the library? add it to the list of dependencies for
> this program). Also it seems to be most consistent with what we
> currently have, see how icu is listed.
As there were no other opinions forthcoming, I have committed it like
this. Thanks!
Commits
-
meson: Add missing dependency to unicode test programs
- 2845cd1ca0cd 18.0 landed