Horton

Re: [BUG] failed assertion in EnsurePortalSnapshotExists()

Drouvot, Bertrand <bdrouvot@amazon.com>

View thread View on postgr.es
From: "Drouvot, Bertrand" <bdrouvot@amazon.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Ranier Vilela <ranier.vf@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-09-30T09:52:52Z
Lists: pgsql-hackers

Attachments

On 9/29/21 10:11 PM, Tom Lane wrote:
> "Drouvot, Bertrand" <bdrouvot@amazon.com> writes:
>> But make check is now failing on join_hash.sql, I have been able to
>> repro with:
> Oh, duh, should have thought a bit harder.  createSubid is a sequential
> subtransaction number; it's not the same as the as_level nesting level.
Oh right, thanks for the explanation.
>
> Probably the most effective way to handle this is to add a subtransaction
> nesting-level field to struct Portal, so we can pass that.

Agree, done that way in the new attached patch.

Thanks

Bertrand

Commits

  1. Fix Portal snapshot tracking to handle subtransactions properly.