Re: killing perl2host

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>

To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2022-02-19T18:04:05Z

Lists: pgsql-hackers

Attachments

0001-remove-perl2host-completely.patch (text/x-patch) patch 0001
0002-remove-most-msys-special-processing.patch (text/x-patch) patch 0002

On 2/16/22 15:46, Andrew Dunstan wrote:
> Largely following a recipe from Andres, I have migrated buildfarm
> animals fairywren and jacana to a setup that shouldn't need (and in fact
> won't be able to use) PostgreSQL::Test:Utils::perl2host(). AFAICT these
> two are the only buildfarm animals that run TAP tests under msys.

[...]


> I suggest that we apply this patch:
>
>
[...]
>
> and if nothing breaks in a few days I will set about a more thorough
> removal of perl2host() and adjusting everywhere it's called, and we can
> forget that the whole sorry mess ever happened :-) I know a number of
> people who will be overjoyed.
>
>


OK, nothing broke, so here are two more invasive patches. The first
removes perl2host completely and adjusts  all the places that use it.
The second removes almost all the remaining msys special processing in
TAP tests.


I have tested these and they appear to work fine.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

Remove PostgreSQL::Test::Utils::perl2host completely
- 95d981338b24 15.0 landed
- b30c62bd42eb 10.21 landed
- b4a6ceed52ee 11.16 landed
- 8358eacc954d 12.11 landed
- c27aa21e0dc8 13.7 landed
- 652ff988fbf6 14.3 landed
Remove most msys special processing in TAP tests
- 1c6d4629394d 15.0 landed
- f1f82301d6c5 11.16 landed
- aa8d4137f990 12.11 landed
- a5716baac00b 13.7 landed
- 8b5cd373ba03 14.3 landed
- 2b02cadb5cbc 10.21 landed
Ensure the right perl is used for TAP tests on msys
- cf12541f2bd5 15.0 landed
Disable perl2host() processing in TAP tests
- f1ac4a74dee5 15.0 landed