Re: [HACKERS] [PATCH] Incremental sort

Tomas Vondra <tomas.vondra@2ndquadrant.com>

From: Tomas Vondra <tomas.vondra@2ndquadrant.com>

To: Teodor Sigaev <teodor@sigaev.ru>, Alexander Korotkov <a.korotkov@postgrespro.ru>, Darafei Komяpa Praliaskouski <me@komzpa.net>

Cc: Antonin Houska <ah@cybertec.at>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2018-03-28T13:44:56Z

Lists: pgsql-hackers

On 03/28/2018 03:28 PM, Teodor Sigaev wrote:
>> BTW, patch had conflicts with master.  Please, find rebased version
>> attached.
> 
> Despite by patch conflist patch looks commitable, has anybody objections
> to commit it?
> 
> Patch recieved several rounds of review during 2 years, and seems to me,
> keeping it out from sources may cause a lost it. Although it suggests
> performance improvement in rather wide usecases.
> 

No objections from me - if you want me to do one final round of review
after the rebase (not sure how invasive it'll turn out), let me know.

BTW one detail I'd change is name of the GUC variable. enable_incsort
seems unnecessarily terse - let's go for enable_incremental_sort or
something like that.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

Further adjustments to Hashagg EXPLAIN ANALYZE output
- 40efbf8706cd 14.0 cited
Rework EXPLAIN format for incremental sort
- 6a918c3ac8a6 13.0 landed
Fix typos and improve incremental sort comments
- 1a40d37a9faf 13.0 landed
Stabilize incremental_sort tests
- cea09246e578 13.0 landed
Minor improvements in Incremental Sort explain
- d22782a5392f 13.0 landed
Consider Incremental Sort paths at additional places
- ba3e76cc571e 13.0 landed
Fix representation of SORT_TYPE_STILL_IN_PROGRESS.
- c7654f6a3779 13.0 landed
Fix failures in incremental_sort due to number of workers
- 23ba3b5ee278 13.0 landed
Fix show_incremental_sort_info with force_parallel_mode
- 7d6d82a52493 13.0 landed
Implement Incremental Sort
- d2d8a229bc58 13.0 landed
Fix handling of "Subplans Removed" field in EXPLAIN output.
- 7d91b604d9b5 13.0 cited
Fix EXPLAIN (SETTINGS) to follow policy about when to print empty fields.
- 3ec20c7091e9 13.0 cited
Ensure plpgsql result tuples have the right composite type marking.
- 5683b34956b4 13.0 cited
Propagate sort instrumentation from workers back to leader.
- bf11e7ee2e36 11.0 cited
Make new regression test case parallel-safe, and improve its output.
- 1177ab1dabf7 11.0 cited
Push limit through subqueries to underlying sort, where possible.
- 1f6d515a67ec 11.0 cited
Fix inappropriate printing of never-measured times in EXPLAIN.
- 4b234fd8bf21 9.6.0 cited
Fix some infelicities in EXPLAIN output for parallel query plans.
- 8ebb69f85445 9.6.0 cited