Re: pgbench: new feature allowing to launch shell commands

Michael Paquier <michael.paquier@gmail.com>

View thread

From: Michael Paquier <michael.paquier@gmail.com>

To: Greg Smith <greg@2ndquadrant.com>

Cc: Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>, pgsql-hackers@postgresql.org

Date: 2009-12-15T00:44:07Z

Lists: pgsql-hackers

Attachments

pgbenchshell_20091215.patch (text/x-patch) patch

Hi,

Yeah the grammar ":variable" is used to set a parameter, the user will feel
disorientated if there is no support.
The attached patch supports this new case, based on Itagaki-san's last
version. I also added a warning to tell the user that pgbench is slowing
down when using this feature.

If nobody is against it, I will mark it as ready to commit.

-- 
Regards,

Michael Paquier
NIPPON TELEGRAPH AND
TELEPHONE CORPORATION
NTT Open Source Software Center